Conversation
These are the types cimgr, cihostlet and ciguestlet use to talk to each other: VM creation options and status (guestlet, statustype), host info and the hostinfo websocket messages (worktype, hostlet), boot logs (bootlog), identifiers and labels (ciid, labels, guestlettype, cinet), the cimgr VM API response (cimgr/cimgrapi), and VM image resolution (vmimage). They're a closed, stdlib-only import graph, so they move here as is, with only import paths rewritten and license headers added. Corp will import them from here. Updates tailscale/corp#49137 Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com> Co-authored-by: Irbe Krumina <irbe@tailscale.com> Co-authored-by: Sam Wronski <samw@tailscale.com> Co-authored-by: Joe Tsai <joetsai@digital-static.net> Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> Change-Id: Ib06d152dff1e861bfc86a921fa1001271fcbd387
runewake2
approved these changes
Sep 29, 2026
tomhjp
approved these changes
Sep 30, 2026
tomhjp
left a comment
tomhjp
left a comment
Member
There was a problem hiding this comment.
Personally I would slightly prefer to preserve git history but I'm not strongly opinionated either way. LGTM as long as we follow up with the other major CI components fairly quickly, or it will get painful splitting PRs across 2 repos.
Member
Author
|
I'd also prefer to keep the git history. Will do. |
Member
Author
|
Actually, closing for now. We'll do a bigger move all at once later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the types cimgr, cihostlet and ciguestlet use to talk to each
other: VM creation options and status (guestlet, statustype), host info
and the hostinfo websocket messages (worktype, hostlet), boot logs
(bootlog), identifiers and labels (ciid, labels, guestlettype, cinet),
the cimgr VM API response (cimgr/cimgrapi), and VM image resolution
(vmimage).
They're a closed, stdlib-only import graph, so they move here as is,
with only import paths rewritten and license headers added. Corp will
import them from here.
Updates tailscale/corp#49137
Co-authored-by: Tom Proctor
Co-authored-by: Irbe Krumina
Co-authored-by: Sam Wronski
Co-authored-by: Joe Tsai