Repository navigation
Make Argument Clinic exit with an error if a warning was emitted - #158930
Open
StanFromIreland wants to merge 2 commits into
Open
StanFromIreland wants to merge 2 commits into
StanFromIreland wants to merge 2 commits into
Conversation
StanFromIreland
requested review from
AA-Turner and
erlend-aasland
as code owners
October 6, 2026 18:59
cmaloney
approved these changes
Oct 6, 2026
cmaloney
left a comment
cmaloney
left a comment
Contributor
There was a problem hiding this comment.
Seems like maybe this should be a -Werror type option in the CI?
Would be nice to have some form of tests (run clinic on a text snippet which produces a warning and check the exit code) to help make sure this doesn't regress.
Member
Author
I thought about this, however, if it's failing in the CI I think users would prefer for it to also fail, to catch such things before pushing.
Sure, added. |
cmaloney
approved these changes
Oct 6, 2026
cmaloney
left a comment
cmaloney
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the test, looks good to me. Makes sense we can change default behavior and having only one behavior is nice when possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would have avoided #158892.