Repository navigation
curl_setopt(_array): document ValueError for invalid options - #5922
Merged
lacatoire merged 2 commits intoOct 9, 2026
Merged
Conversation
Add Errors sections and PHP 8.0.0 changelog entries noting that invalid cURL options now throw ValueError instead of emitting E_WARNING (php/php-src#5963 / PHP 8 internal function exceptions). Closes php#3119
lacatoire
reviewed
Oct 9, 2026
lacatoire
reviewed
Oct 9, 2026
lacatoire
requested changes
Oct 9, 2026
lacatoire
left a comment
lacatoire
left a comment
Member
There was a problem hiding this comment.
Thanks @SatvikMishra08 a few nits & some lint nits but LGTM
lacatoire
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3119
Documents the PHP 8.0 change where invalid cURL options raise a
ValueErrorinstead of emitting anE_WARNING(see php/php-src#5963 and the general PHP 8 internal-function exception promotion).Changes
curl_setopt: add Errors section; add 8.0.0 Changelog row for invalid-optionValueErrorcurl_setopt_array: same Errors + Changelog treatment for invalid options in the options arrayExisting Changelog rows (e.g. CurlHandle parameter, new constants) are left unchanged.