Skip to content

chore(bson-parsing): integration with compass - #910

Draft
mabaasit wants to merge 5 commits into
timout-long-running-workerfrom
integration-clean-up
Draft

mabaasit wants to merge 5 commits into
timout-long-running-workerfrom
integration-clean-up

Conversation

@mabaasit

@mabaasit mabaasit commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Description

Open Questions

Checklist


Stack created with GitHub Stacks CLI • Give Feedback 💬

@mabaasit
mabaasit added this pull request to stack #894 October 5, 2026 13:01
Copilot AI balanced review requested due to automatic review settings October 5, 2026 13:04
@mabaasit
mabaasit force-pushed the integration-clean-up branch from a141a27 to 504988a Compare October 5, 2026 13:04
@mabaasit mabaasit changed the title chore: integratino with compass change chore(bson-parsing): integration with compass Oct 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The test imports named exports from a worker file that Webpack overwrites with a non-exporting IIFE bundle.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Updates the BSON parser worker for Compass compatibility while preserving parser error types.

Changes:

  • Renames worker artifacts to .mjs.
  • Transfers Error objects across the worker boundary.
  • Adds error-type preservation coverage.
File Description
webpack.worker.config.cjs Bundles the worker as worker.mjs.
src/​worker.mts Returns parser errors directly.
src/​worker-types.ts Types worker failures as Error.
src/​worker-client.ts Loads .mjs and rejects with transferred errors.
src/​index.spec.ts Updates worker paths and tests error preservation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

ALLOWED_GLOBALS,
DISALLOWED_PROTOTYPE_PROPS,
} from './worker.js';
} from './worker.mjs';
@mabaasit
mabaasit force-pushed the integration-clean-up branch 2 times, most recently from c4bd7b3 to 107e42d Compare October 5, 2026 15:20
@mabaasit
mabaasit force-pushed the integration-clean-up branch from 107e42d to ca1a8ac Compare October 5, 2026 15:47
@mabaasit
mabaasit force-pushed the integration-clean-up branch from ca1a8ac to 8c55a75 Compare October 5, 2026 19:44
@mabaasit
mabaasit force-pushed the integration-clean-up branch from 8c55a75 to 5126e9d Compare October 5, 2026 20:30
@mabaasit
mabaasit force-pushed the integration-clean-up branch from 6ca851c to 4372c96 Compare October 8, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants