Skip to content

Fix maven package assembly in uberjars - #5346

Open
AyanSinhaMahapatra wants to merge 2 commits into
developfrom
maven-package-assembly
Open

AyanSinhaMahapatra wants to merge 2 commits into
developfrom
maven-package-assembly

Conversation

@AyanSinhaMahapatra

Copy link
Copy Markdown
Member

Fix package assembly in uberjars with multiple pom.xml manifests where we were not assembling package manifests for the original package together.

Reference: aboutcode-org/scancode.io#2248

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Fix package assembly in uberjars with multiple pom.xml manifests
where we were not assembling package manifests for the original package
together.

Reference: aboutcode-org/scancode.io#2248
Signed-off-by: Ayan Sinha Mahapatra <asmahapatra@aboutcode.org>
Signed-off-by: Ayan Sinha Mahapatra <asmahapatra@aboutcode.org>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant