Repository navigation
bug: parse docker images with a registry port - #670
Open
Amadeus-22 wants to merge 1 commit into
Open
Amadeus-22 wants to merge 1 commit into
Amadeus-22 wants to merge 1 commit into
Conversation
DockerImage.parse split on every colon, so localhost:5000/lean was read as name 'localhost' with tag '5000/lean' and localhost:5000/lean:latest raised ValueError. Only the part after the last colon is a tag, and only when it does not contain a slash. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #669.
DockerImage.parsesplit the image on every colon. With a registry that has a port,localhost:5000/leanbecame namelocalhostand tag5000/lean, andlocalhost:5000/lean:latestraisedValueError: too many values to unpack. This affects--imageand theengine-image/research-imageconfig values./in it. Existing inputs parse as before.tests/models/test_docker.py.pytest tests/models/test_docker.pypasses (10 tests) andpython static_analysis.pyis clean.🤖 Generated with Claude Code