Repository navigation
Core: replace Class.abstract() with abstract methods and drop the instanceof Class check in toComparable - #35528
Merged
EugeniyKiyashko merged 3 commits intoOct 7, 2026
Conversation
…tanceof Class check in toComparable
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The public comparison behavior change needs explicit regression coverage.
Review effort: Balanced
Findings: 1
What changed in this PR
Replaces runtime abstract stubs with TypeScript abstract methods and removes legacy Class handling from comparison normalization.
Changes:
- Converts base UI classes to abstract classes and methods.
- Preserves the map provider’s runtime
E0001behavior forupdateDisabled. - Restricts
toComparableunwrapping toGuid.
| File | Description |
|---|---|
animator.ts |
Makes _step abstract. |
provider.ts |
Makes provider operations abstract. |
provider.dynamic.ts |
Makes dynamic-provider hooks abstract. |
form.item_option_action.ts |
Makes item-option actions abstract. |
collection_widget.edit.strategy.ts |
Makes edit-strategy operations abstract. |
m_data.ts |
Removes legacy Class normalization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… does not break the provider action queue, type the provider actions as promises
Raushen
approved these changes
Oct 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.