Repository navigation
Use full OCI tag for pinned injector version - #7971
Merged
Merged
Conversation
auto_inject.lock pinned 0.71.2, but injector OCI tags carry a package revision suffix: install.datadoghq.com has apm-inject-package:0.71.2-1 and returns 404 for 0.71.2. Tracer SSI pipelines that load the pin fail to install the injector. Pin 0.71.2-1 and enforce the suffix in the lock format test.
Contributor
|
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 9d259eb | Docs | View more details | Give us feedback! |
rahulkaukuntla
marked this pull request as ready for review
October 6, 2026 17:44
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
pawelchcki
approved these changes
Oct 6, 2026
bouwkast
approved these changes
Oct 6, 2026
bouwkast
left a comment
bouwkast
left a comment
Contributor
There was a problem hiding this comment.
LGTM and creating a link based off this version works and doesn't 404 like the old one 👍
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
robertomonteromiguel
approved these changes
Oct 6, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: removed
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#7720 pinned the injector to
0.71.2inutils/build/auto_inject.lock. That tag doesn't exist: injector OCI tags have a revision suffix, so the real tag is0.71.2-1. Since #7720 merged, tracer SSI pipelines (e.g. dd-trace-dotnet) fail at injector install:Changes
auto_inject.lock:0.71.2→0.71.2-1.test_auto_inject_lock_formatnow rejects a lock without the-Nsuffix, so this can't regress.Validation
This repo's CI doesn't exercise the pinned path (it only runs when a tracer pipeline supplies a custom library version), so I ran dd-trace-dotnet against this branch with
SYSTEM_TESTS_REF=fix/auto-inject-lock-oci-tag: pipeline 142800342.All 13 SSI jobs passed, including the one that had failed on
main(job 2114237251):