Repository navigation
fix(php): profiling marker checks - #7658
Open
morrisonlevi wants to merge 13 commits into
Open
morrisonlevi wants to merge 13 commits into
morrisonlevi wants to merge 13 commits into
Conversation
Contributor
|
|
morrisonlevi
marked this pull request as ready for review
September 8, 2026 14:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 0bdd024 | Docs | View more details | Give us feedback! |
Run update_mirror_images.py to sync the mirrored image manifest and lock file with the current CI scenarios. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
nccatoni
approved these changes
Sep 29, 2026
Regenerate the base-image lock and mirror image list from the merged sources, preserving the PHP profiling marker fix. Retain upstream mirror digests until GitLab publishes the 25 new PHP base-image tags; rerun update_mirror_images.py afterward.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I'm merging the PHP profiler into the ddtrace.so artifact, meaning there will be no separate datadog-profiling.so artifact anymore once that PR merges.
Changes
Changes the check to work for the old and new setup alike. This way it can be merged before the other PR is merged.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present